Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add v8_embedder_string to build args (backport: 4-0-x) #15120

Merged
merged 1 commit into from Oct 12, 2018
Merged

build: add v8_embedder_string to build args (backport: 4-0-x) #15120

merged 1 commit into from Oct 12, 2018

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 12, 2018

Backport of #15039

See that PR for details.

Notes: v8 embedder version string changed from -node.N to -electron.N

@trop trop bot requested a review from a team October 12, 2018 15:26
@trop trop bot mentioned this pull request Oct 12, 2018
Merged
4 tasks
@trop trop bot added the backport This is a backport PR label Oct 12, 2018
@codebytere codebytere merged commit 948fc6f into electron:4-0-x Oct 12, 2018
@release-clerk
Copy link

release-clerk bot commented Oct 12, 2018

Release Notes Persisted

v8 embedder version string changed from -node.N to -electron.N

@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @nornagon